[Qemu-devel] Re: [PATCH] PPC4xx: don't unregister RAM at reset

[Alexander Graf]

On 02.08.2010, at 21:37, Hollis Blanchard wrote:

> On Mon, Aug 2, 2010 at 1:41 AM, Alexander Graf <address@hidden> wrote:
>> 
>> On 30.07.2010, at 03:48, Hollis Blanchard wrote:
>> 
>>> The PowerPC 4xx SDRAM controller emulation unregisters RAM in its reset
>>> callback. However, qemu_system_reset() is now called at initialization
>>> time, so RAM is unregistered before starting the guest.
>> 
>> So the registration should be moved to reset now, no? How is the reset 
>> different from boot? How did a reset work before?
> 
> As far as I can tell, no other platform unregisters and re-registers
> memory at reset, so that is a difference between reset and boot.
> 
> Maybe I don't understand your other question. Before
> qemu_system_reset() was called at initialization time, memory was not
> unregistered, and therefore the platform had memory and could boot.

Then removal of the unregister is sane and the reset path was broken before. 
That's good to know :).

Alex