Re: [Qemu-devel] RFC adding ioctl's to virtserial/virtconsole

[Anthony Liguori]

On 08/03/2010 11:42 AM, Gerd Hoffmann wrote:
> > > > understand what state the session is in.
> > >
> > > Spice would basically (ab-)use it as event delivery mechanism.
> >
> > Can you explain what spice uses these events for?
> Spice would then implement it's own CharServerState and would use it to
>
> spice-vmc code registers/unregisters the interface within the spice 
> server.  So the interface is only activated in case the guest uses it. 
> Spice client sees the interface being active or not and can act 
> accordingly.

So we have to migrate connected state?

> > > Well. I disagree. Checking the state is needed nevertheless. The
> > > places where virtio-serial checks port->state today it would have to
> > > check whenever port->chardev is non-NULL then. The only difference is
> > > that failures to do so might become a bit more obvious as qemu will
> > > segfault due to the NULL pointer dereferences then. I still think this
> > > isn't worth the effort though.
> >
> > But I think we ultimately need to switch to having the front-ends having
> > a NULL check. Even beyond front-end initiated connect/disconnect,
> > front-end's need to learn to deal with back-end initiated
> > disconnect/connect.
>
> I don't think we have to go with a NULL check.  Providing chr_is_*() 
> functions to query state and adding asserts() to the chr_*() function 
> should provide the same level of robustness IMHO.  Also having 
> CharDriverStates come and go brings its own share of problems.

I think this would be a reasonable solution too.

Regards,

Anthony Liguori