Re: [Qemu-devel] [RFC PATCH 0/4] AMD IOMMU emulation 2nd version

[Blue Swirl]

On Wed, Aug 4, 2010 at 10:32 PM, Eduard - Gabriel Munteanu
<address@hidden> wrote:
> Hi,
>
> I hope I solved the issues raised by Anthony and Paul.
>
> Please have a look and tell me what you think. However, don't merge it yet (in
> case you like it), I need to test and cleanup some pieces further. There are
> also some patches from the previous series I didn't include yet.
>
>
>        Thanks,
>        Eduard
>
> Eduard - Gabriel Munteanu (4):
>  pci: memory access API and IOMMU support
>  AMD IOMMU emulation
>  ide: use the PCI memory access interface
>  rtl8139: use the PCI memory access interface

The patches violate CODING_STYLE regarding structure naming and use of
braces, please fix.

>
>  Makefile.target   |    2 +
>  configure         |   10 +
>  dma-helpers.c     |   37 +++-
>  dma.h             |   21 ++-
>  hw/amd_iommu.c    |  671 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/ide/core.c     |   15 +-
>  hw/ide/internal.h |   39 +++
>  hw/ide/pci.c      |    7 +
>  hw/pc.c           |    4 +
>  hw/pc.h           |    3 +
>  hw/pci.c          |  145 ++++++++++++
>  hw/pci.h          |  130 +++++++++++
>  hw/pci_ids.h      |    2 +
>  hw/pci_regs.h     |    1 +
>  hw/rtl8139.c      |   99 +++++----
>  qemu-common.h     |    1 +
>  16 files changed, 1134 insertions(+), 53 deletions(-)
>  create mode 100644 hw/amd_iommu.c
>
>
>