Re: [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix

[Daniel P. Berrange]

On Wed, Jun 23, 2010 at 08:14:04PM +0530, Amit Shah wrote:
> qemu-config.c doesn't contain any target-specific code, and the
> TARGET_I386 conditional code didn't get compiled as a result. Removing
> this enables the driftfix parameter for rtc.
> 
> Signed-off-by: Amit Shah <address@hidden>
> ---
>  qemu-config.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-config.c b/qemu-config.c
> index 95abe61..730ffd9 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -247,11 +247,9 @@ QemuOptsList qemu_rtc_opts = {
>          },{
>              .name = "clock",
>              .type = QEMU_OPT_STRING,
> -#ifdef TARGET_I386
>          },{
>              .name = "driftfix",
>              .type = QEMU_OPT_STRING,
> -#endif
>          },
>          { /* end if list */ }
>      },


Is there any reason this patch hasn't been applied to GIT yet ? I'm told 
that using this option is critical to making certain guests work reliably
so we want to use it from libvirt/virt-manager for the OS in question.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|