Re: [Qemu-devel] [PATCH] Added an option to set the VMDK adapter type

[Aaron Mason]

Let's try that again.

I'd paste it but GMail likes to break patches to honour the 73 char
limit.  I'll install Git on my home PC and try git send-email from
there (my work PC is behind a restrictive firewall so email via Gmail
is out).

Thanks for finding more that I missed, I'll fix them on Monday next
time I'm in the office.

On Thu, Aug 5, 2010 at 7:07 AM, Aaron Mason
<address@hidden> wrote:
> there
>
> sent from my Telstra NEXTG™ handset
>
> -----Original Message-----
> From: Kevin Wolf <address@hidden>
> Sent: Wednesday, 4 August 2010 10:29 PM
> To: andrzej zaborowski <address@hidden>
> Cc: Aaron Mason <address@hidden>; address@hidden
> Subject: Re: [Qemu-devel] [PATCH] Added an option to set the VMDK adapter type
>
> Am 04.08.2010 14:27, schrieb andrzej zaborowski:
>> Hi,
>>
>> On 4 August 2010 12:30, Kevin Wolf <address@hidden> wrote:
>>> Am 04.08.2010 01:46, schrieb Aaron Mason:
>>>> +    const char *real_filename, *temp_str, *adapterType = "ide";
>>
>> Sorry to complain about style, but note that uppercase characters are
>> not used in variable names in Qemu (that I see).
>
> Whoops, missed that one when complaining about the other style problems.
> Yes, this should be adapter_type.
>
> Kevin
>