Re: [Qemu-devel] [PATCH 14/15] vnc: tight: tweak adaptive tight settings

[Chris Krumme]

Hello Corentin,

On 08/11/2010 12:49 AM, Corentin Chary wrote:
> The force_jpeg threshold was too low.
>
> Signed-off-by: Corentin Chary<address@hidden>
> ---
>   qemu-thread.c      |    1 +
>   ui/vnc-enc-tight.c |   20 ++++++++++----------
>   2 files changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/qemu-thread.c b/qemu-thread.c
> index fbc78fe..4094c51 100644
> --- a/qemu-thread.c
> +++ b/qemu-thread.c
> @@ -22,6 +22,7 @@
>   static void error_exit(int err, const char *msg)
>   {
>       fprintf(stderr, "qemu: %s: %s\n", msg, strerror(err));
> +    char *p = NULL; *p = 1;
>    

I do not believe this is the official way to do an assert.  It is also 
not documented in the change comments.

Thanks

Chris

>       exit(1);
>   }
>
> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
> index 9f83235..b0181ff 100644
> --- a/ui/vnc-enc-tight.c
> +++ b/ui/vnc-enc-tight.c
> @@ -79,16 +79,16 @@ static const struct {
>       int jpeg_idx;               /* Allow indexed JPEG */
>       int jpeg_full;              /* Allow full color JPEG */
>   } tight_jpeg_conf[] = {
> -    { 0,   4,  1, 1 },
> -    { 0,   4,  1, 1 },
> -    { 0,   4,  1, 1 },
> -    { 0,   4,  1, 1 },
> -    { 0,   4,  0, 1 },
> -    { 0.1, 4,  0, 1 },
> -    { 0.2, 4,  0, 1 },
> -    { 0.3, 6,  0, 0 },
> -    { 0.4, 8,  0, 0 },
> -    { 0.5, 10, 0, 0 },
> +    { 0,   8,  1, 1 },
> +    { 0,   8,  1, 1 },
> +    { 0,   8,  1, 1 },
> +    { 0,   8,  1, 1 },
> +    { 0,   10, 1, 1 },
> +    { 0.1, 10, 1, 1 },
> +    { 0.2, 10, 1, 1 },
> +    { 0.3, 12, 0, 0 },
> +    { 0.4, 14, 0, 0 },
> +    { 0.5, 16, 0, 0 },
>   };
>   #endif
>
>