Re: [Qemu-devel] [PATCH 8/9] spice: simple display

[Alexander Graf]

On 19.08.2010, at 17:34, Anthony Liguori wrote:

> On 08/19/2010 10:23 AM, malc wrote:
>> 
>>>> +
>>>> +void qemu_spice_destroy_update(SimpleSpiceDisplay *sdpy, SimpleSpiceUpdate
>>>> *update)
>>>> +{
>>>> +    qemu_free(update->bitmap);
>>>> +    qemu_free(update);
>>>> +}
>>>> +
>>>> +void qemu_spice_create_host_memslot(SimpleSpiceDisplay *ssd)
>>>> +{
>>>> +    QXLDevMemSlot memslot;
>>>> +
>>>> +    if (debug)
>>>> +        fprintf(stderr, "%s:\n", __FUNCTION__);
>>>> 
>>>>       
>>> a dprintf() would better fit qemu's style.
>>>     
>> A dprintf is a POSIX function.
>>   
> 
> Apparently a recent POSIX function...

In my man page it's declared as

       #define _GNU_SOURCE
       #include <stdio.h>

       int dprintf(int fd, const char *format, ...);

but maybe it did become POSIX recently. Either way, it's used already :).

> Preferred alternatives?  I really dislike all caps macros.

printd should be fine.

Alex