qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] vnc: check fd before calling qemu_set_fd_handle


From: Corentin Chary
Subject: [Qemu-devel] Re: [PATCH] vnc: check fd before calling qemu_set_fd_handler2() in vnc_client_write()
Date: Fri, 20 Aug 2010 16:17:11 +0200

On Fri, Aug 20, 2010 at 12:10 PM, Yoshiaki Tamura
<address@hidden> wrote:
> Setting fd = -1 to qemu_set_fd_handler2() causes bus error at FD_SET
> in main_loop_wait().
>
> Signed-off-by: Yoshiaki Tamura <address@hidden>
> ---
>  ui/vnc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 7fc40ac..c7a1831 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -1184,7 +1184,7 @@ void vnc_client_write(void *opaque)
>     vnc_lock_output(vs);
>     if (vs->output.offset) {
>         vnc_client_write_locked(opaque);
> -    } else {
> +    } else if (vs->csock != -1) {
>         qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read, NULL, vs);
>     }
>     vnc_unlock_output(vs);
> --
> 1.7.1.1
>
>

Acked-By: Corentin Chary <address@hidden>

-- 
Corentin Chary
http://xf.iksaif.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]