qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/14] trace: Add trace-events file for declarin


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 01/14] trace: Add trace-events file for declaring trace events
Date: Sun, 22 Aug 2010 16:38:36 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100713 Lightning/1.0b1 Thunderbird/3.0.6

On 08/12/2010 05:36 AM, Stefan Hajnoczi wrote:
+linetoh_nop()
+{
+    local name args
+    name=$(get_name "$1")
+    args=$(get_args "$1")
+
+    # Define an empty function for the trace event
+    cat<<EOF
+static inline void trace_$name($args)
+{
+}

This seems like it can potentially create a single header that ends up needed to know about every type of structure QEMU implements, no? If so, this would be challenging for improving modularity.

Or would we restrict trace points to not allow passing of anything but void *s?

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]