Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

[Jes Sorensen]

On 08/22/10 22:39, Avi Kivity wrote:
>  On 08/22/2010 10:44 PM, malc wrote:
>>
>>> There is the problem that some patch submitters are reminded of
>>> CODING_STYLE while others aren't. Some don't need to be reminded but
>>> they are not part of the problem.
>> And to this i fully subscribe.
> 
> I agree.
> 
> From my Linux experience, I started out whining about each and every
> coding style violation.  To my own great self-annoyance.  After a while
> all contributors adjusted and now this is quite rare.
> 
> Enforce the coding style with an iron hand, and pretty soon you won't
> have to.

Well with the inconsistency we have now, what is the right iron fist to
apply? Demand the code is consistent with the file you edit or that it's
consistent with whats in CODING_STYLE, even if it means that what you
apply is completely different to the rest of the file?

That is the part I think needs to be decided upon in all of this.

Jes