Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

[john cooper]

Jes Sorensen wrote:
> On 08/22/10 20:39, malc wrote:
>   
>> Disregarding my own stance on the braces, braces around single statement
>> is actually helpful w.r.t. debugging imaging trying to set a break point
>> on said singlesttement, plain impossible in following case:
>>
>> if (a) b;
>>     
>
> Oh there is no talk about suggesting we force things onto a single line.
> Putting if(foo) bar(); on the same line is just plain wrong, what I
> referred to was this:
>
>     if (foo)
>         bar();
>
> vs
>     if (foo) {
>         bar();
>     }
>
> If it is part of a multi-block if()/else block yes it's good for
> consistency, if it is a one off in the code, it doesn't add any value
> IMHO, it is a loss because it wastes space for no reason.
>   
About the only benefit I've found for that added syntactic sugar
is simplifying debug somewhat as you aren't falling in/out of the
grammar optimization.

But from a maintainability perspective, where possible I avoid
formatting which dilutes the information content in a code window.
It negatively impacts readability IMHO.

-john