[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging |
Date: |
Tue, 24 Aug 2010 00:54:33 +0200 |
On 24.08.2010, at 00:50, Anthony Liguori wrote:
> On 08/23/2010 05:45 PM, Alexander Graf wrote:
>>> Device_add already works with this set and only required minor changes the
>>> s390 specific code. So that part was pretty slick :). The part that didn't
>>> work was the drive_add one.
>>>
>>> What is blockdev_add supposed to be? drive_add without IF_SCSI?
>
> drive_add without if= and without the PCI-isms.
>
>>> To be a bit more precise on how things work with this set:
>>>
>>> (qemu) drive_add 0 id=my_disk,if=none,file=/dev/null
>>> OK
>>>
>
> In theory, something like:
>
> (qemu) blockdev_add id=my_disk,file=/dev/null
So why add yet another command when we could use the existing drive_add?
Wouldn't it make more sense to deprecate if=!none, move forward from there,
make if=none the default and around 0.16 or so drop if= from drive_add?
Alex
Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging, Daniel P. Berrange, 2010/08/24
- Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging, Alexander Graf, 2010/08/24
- Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging, Daniel P. Berrange, 2010/08/24
- Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging, Alexander Graf, 2010/08/24
- Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging, Daniel P. Berrange, 2010/08/24
- Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging, Alexander Graf, 2010/08/24
- Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging, Daniel P. Berrange, 2010/08/24
- Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging, Markus Armbruster, 2010/08/27
Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging, Anthony Liguori, 2010/08/24
Re: [Qemu-devel] [PATCH 4/5] Add generic drive hotplugging, Alexander Graf, 2010/08/24