Re: [Qemu-devel] [PATCH 2/4] scsi-disk: fix the mode data header returned by the MODE SENSE(10) command

[Bernhard Kohl]

Am 16.08.2010 19:02, schrieb ext Kevin Wolf:
> > +    if (bdrv_get_type_hint(s->bs) == BDRV_TYPE_CDROM ||
> > +        bdrv_is_read_only(s->bs)) {
>
> This looks like a mismerge. The check for CDROMs was removed when they
> became read-only by definition. Please don't reintroduce it.
OK, I will remove that check in v2.
> > +        if (req->cmd.buf[0] == MODE_SENSE)
> > +            outbuf[3] = 8; /* Block descriptor length  */
> > +        else /* MODE_SENSE_10 */
> > +            outbuf[7] = 8; /* Block descriptor length  */
>
> Please add curly braces here (see CODING_STYLE).
OK, I will add curly braces in v2.

Bernhard