Re: [Qemu-devel] Re: [PATCH v3] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

[Markus Armbruster]

Anthony Liguori <address@hidden> writes:

> On 08/30/2010 03:16 AM, address@hidden wrote:
>> From: Jes Sorensen<address@hidden>
>>
>> pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup
>> at init time, it is not possible to load an option ROM for a hotplug
>> device when running in compat mode.
>>
>> v2: Alex Williamson pointed out that one can get to qdev directly from
>> pci_dev, so no need to pass it down.
>>
>> v3: Braces
>>    
>
> What's the specific bug?  The devices themselves have a check for
> hotplug which inhibits rom addition during hotplug so either there's a
> device missing this check or if we're going to go this route, we ought
> to remove those checks in the other devices.

Quoting my reply to v1[*]:

    Example:

        $ qemu -M pc-0.11 -S -monitor stdio
        QEMU 0.12.50 monitor - type 'help' for more information
        (qemu) device_add e1000
        qemu: hardware error: ROM images must be loaded at startup
    [...]
        Aborted (core dumped)

    The fix silently omits the option ROM when we can't load it.  Works for
    me.

[*] http://lists.nongnu.org/archive/html/qemu-devel/2010-07/msg01397.html