|
From: | Anthony Liguori |
Subject: | [Qemu-devel] Re: [PATCH 05/14] Remove unused argument for check_for_block_signature() |
Date: | Mon, 30 Aug 2010 13:27:52 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100713 Lightning/1.0b1 Thunderbird/3.0.6 |
On 08/30/2010 01:19 PM, Jes Sorensen wrote:
I totally agree on this. The problem with having such arguments passed in is that you never know if they were used in the past and it was forgotten when the code using them was removed, or if it's new code, in which case they do deserve the extra scrutiny.
Or, we exercise common sense instead of blinding removing arguments just because a certain uncommon warning mode of GCC complains.
Regards, Anthony Liguori
Cheers, Jes
[Prev in Thread] | Current Thread | [Next in Thread] |