[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 4/6] scsi-disk: fix the block descriptor returned
From: |
Bernhard Kohl |
Subject: |
[Qemu-devel] [PATCH v3 4/6] scsi-disk: fix the block descriptor returned by the MODE SENSE command |
Date: |
Tue, 31 Aug 2010 14:08:25 +0200 |
The block descriptor contains the number of blocks, not the highest LBA.
Real hard disks return 0 if the number of blocks exceed the maximum 0xFFFFFF.
SCSI-Spec:
http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.3.3
"The number of blocks field specifies the number of logical blocks on the
medium to which the density code and block length fields apply. A value
of zero indicates that all of the remaining logical blocks of the logical
unit shall have the medium characteristics specified."
Signed-off-by: Bernhard Kohl <address@hidden>
---
hw/scsi-disk.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 1287cab..e085d5b 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -662,9 +662,8 @@ static int scsi_disk_emulate_mode_sense(SCSIRequest *req,
uint8_t *outbuf)
outbuf[7] = 8; /* Block descriptor length */
}
nb_sectors /= s->cluster_size;
- nb_sectors--;
if (nb_sectors > 0xffffff)
- nb_sectors = 0xffffff;
+ nb_sectors = 0;
p[0] = 0; /* media density code */
p[1] = (nb_sectors >> 16) & 0xff;
p[2] = (nb_sectors >> 8) & 0xff;
--
1.7.2.2
- [Qemu-devel] [PATCH v3 0/6] scsi-disk: improve the emulation of the MODE SENSE command, Bernhard Kohl, 2010/08/31
- [Qemu-devel] [PATCH v3 2/6] scsi-disk: fix the mode data header returned by the MODE SENSE(10) command, Bernhard Kohl, 2010/08/31
- [Qemu-devel] [PATCH v3 6/6] scsi-disk: fix the check of the DBD bit in the MODE SENSE command, Bernhard Kohl, 2010/08/31
- [Qemu-devel] [PATCH v3 4/6] scsi-disk: fix the block descriptor returned by the MODE SENSE command,
Bernhard Kohl <=
- [Qemu-devel] [PATCH v3 5/6] scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command, Bernhard Kohl, 2010/08/31
- [Qemu-devel] [PATCH v3 1/6] scsi-disk: fix the mode data length field returned by the MODE SENSE command, Bernhard Kohl, 2010/08/31
- [Qemu-devel] [PATCH v3 3/6] scsi-disk: respect the page control (PC) field in the MODE SENSE command, Bernhard Kohl, 2010/08/31
- [Qemu-devel] Re: [PATCH v3 0/6] scsi-disk: improve the emulation of the MODE SENSE command, Kevin Wolf, 2010/08/31