[Qemu-devel] Re: [PATCH 0/5] virtio-net: More configurability and bh handling for tx

[Michael S. Tsirkin]

On Fri, Aug 27, 2010 at 04:36:59PM -0600, Alex Williamson wrote:
> Add the ability to configure the tx_timer timeout and add a bottom
> half tx handler that typically shows a nice perf boost over the
> time based approach.  See last patch for perf details.  Make this
> the new default when the iothread is enabled.  Thanks,
> 
> Alex

Looks good overall, but do we really want to make these parameters qdev 
properties?
It really looks like exposing an implementation detail that we'll have hard
time supporting in the future and users will have hard time
understanding. OTOH developers should have no trouble tweaking
a define on top of the file.



> ---
> 
> Alex Williamson (5):
>       virtio-net: Switch default to new bottom half TX handler for iothread
>       virtio-net: Introduce a new bottom half packet TX
>       virtio-net: Rename tx_timer_active to tx_waiting
>       virtio-net: Limit number of packets sent per TX flush
>       virtio-net: Make tx_timer timeout configurable
> 
> 
>  hw/s390-virtio-bus.c |    6 ++
>  hw/s390-virtio-bus.h |    4 ++
>  hw/syborg_virtio.c   |   10 +++-
>  hw/virtio-net.c      |  129 
> ++++++++++++++++++++++++++++++++++++++++----------
>  hw/virtio-net.h      |    2 -
>  hw/virtio-pci.c      |   10 +++-
>  hw/virtio.h          |    9 +++
>  7 files changed, 137 insertions(+), 33 deletions(-)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to address@hidden
> More majordomo info at  http://vger.kernel.org/majordomo-info.html