[Qemu-devel] Re: [PATCH 0/5] virtio-net: More configurability and bh handling for tx

[Michael S. Tsirkin]

On Tue, Aug 31, 2010 at 04:26:07PM -0600, Alex Williamson wrote:
> On Tue, 2010-08-31 at 16:33 -0500, Anthony Liguori wrote:
> > On 08/31/2010 03:27 PM, Michael S. Tsirkin wrote:
> > > On Fri, Aug 27, 2010 at 04:36:59PM -0600, Alex Williamson wrote:
> > >    
> > >> Add the ability to configure the tx_timer timeout and add a bottom
> > >> half tx handler that typically shows a nice perf boost over the
> > >> time based approach.  See last patch for perf details.  Make this
> > >> the new default when the iothread is enabled.  Thanks,
> > >>
> > >> Alex
> > >>      
> > > As a further thought, maybe it would help to have a
> > > separate namespace for unsupported, developer-only parameters.
> > > Thoughts?
> > >    
> > 
> > We already have an undocumented one, just prefix with 'x-' to indicate 
> > that it's experimental.
> 
> Any objection then to x-txburst and x-txtimer then?  Easy enough to
> rename.  Thanks,
> 
> Alex

No objection. Let's put the 256 constant in a header,
with a comment explaining where it came from?

-- 
MST