[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 9/9] msix: clear not only INTA, but all INTx
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH v2 9/9] msix: clear not only INTA, but all INTx when MSI-X is enabled. |
Date: |
Wed, 8 Sep 2010 13:33:37 +0300 |
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Wed, Sep 08, 2010 at 04:39:42PM +0900, Isaku Yamahata wrote:
> clear not only INTA, but all INTx when MSI-X is enabled.
>
> Signed-off-by: Isaku Yamahata <address@hidden>
Nod. This makes sense.
> ---
> hw/msix.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/hw/msix.c b/hw/msix.c
> index 7ce63eb..b202ff7 100644
> --- a/hw/msix.c
> +++ b/hw/msix.c
> @@ -158,6 +158,7 @@ void msix_write_config(PCIDevice *dev, uint32_t addr,
> {
> unsigned enable_pos = dev->msix_cap + MSIX_CONTROL_OFFSET;
> int vector;
> + int i;
>
> if (!range_covers_byte(addr, len, enable_pos)) {
> return;
> @@ -167,7 +168,9 @@ void msix_write_config(PCIDevice *dev, uint32_t addr,
> return;
> }
>
> - qemu_set_irq(dev->irq[0], 0);
> + for (i = 0; i < PCI_NUM_PINS; ++i) {
> + qemu_set_irq(dev->irq[i], 0);
> + }
>
> if (msix_function_masked(dev)) {
> return;
> --
> 1.7.1.1
- [Qemu-devel] [PATCH v2 0/9] pcie port switch emulators, Isaku Yamahata, 2010/09/08
- [Qemu-devel] [PATCH v2 9/9] msix: clear not only INTA, but all INTx when MSI-X is enabled., Isaku Yamahata, 2010/09/08
- [Qemu-devel] Re: [PATCH v2 9/9] msix: clear not only INTA, but all INTx when MSI-X is enabled.,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH v2 8/9] pcie/aer: glue aer error injection into qemu monitor., Isaku Yamahata, 2010/09/08
- [Qemu-devel] [PATCH v2 5/9] pcie upstream port: pci express switch upstream port., Isaku Yamahata, 2010/09/08
- [Qemu-devel] [PATCH v2 1/9] msi: implemented msi., Isaku Yamahata, 2010/09/08
- [Qemu-devel] [PATCH v2 3/9] pcie port: define struct PCIEPort/PCIESlot and helper functions, Isaku Yamahata, 2010/09/08
- [Qemu-devel] [PATCH v2 6/9] pcie downstream port: pci express switch downstream port., Isaku Yamahata, 2010/09/08
- [Qemu-devel] [PATCH v2 7/9] pcie/hotplug: glue pushing attention button command. pcie_abp, Isaku Yamahata, 2010/09/08