qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] block-nbd: fix use of protocols in backing


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 2/3] block-nbd: fix use of protocols in backing files and nbd probing
Date: Sat, 11 Sep 2010 12:45:48 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100826 Lightning/1.0b1 Thunderbird/3.0.7

On 09/11/2010 12:27 PM, Anthony Liguori wrote:
I think the better solution is to explicitly specific raw with nbd. IOW, I think -drive file=nbd:localhost:1026,format=raw should work the same way. I still feel slightly weird about probing happening with nbd. It seems like it could only result in badness.

Yeah, w/o this patch, 'qemu-img create -f qcow2 -b nbd:localhost:1026 -o backing_fmt=raw foo.img' doesn't generate any reads although if you drop -o backing_fmt, it will.

Not sure I agree it's the most useful thing, but I'm not going to claim it's never useful so this patch is not a good idea.

Regards,

Anthony Liguori


The specific scenario is migration. I'm using a copy-on-read file on the destination and I want to be sure that I don't read any blocks (since they're copied) until the source stops execution.

Regards,

Anthony Liguori

Stefan






reply via email to

[Prev in Thread] Current Thread [Next in Thread]