qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 2/3] pci: don't ignore invalid parameter for pci


From: Michael S. Tsirkin
Subject: [Qemu-devel] Re: [PATCH 2/3] pci: don't ignore invalid parameter for pci_register_bar().
Date: Sun, 12 Sep 2010 17:21:06 +0200
User-agent: Mutt/1.5.20 (2009-12-10)

On Thu, Sep 09, 2010 at 11:48:56AM +0900, Isaku Yamahata wrote:
> Abort when invalid value for region_num is passed to pci_register_bar.
> That is caller's bug. Abort instead of silently ignoring invalid value.
> 
> Signed-off-by: Isaku Yamahata <address@hidden>
> ---
>  hw/pci.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)

Applied.

> diff --git a/hw/pci.c b/hw/pci.c
> index 8d6b299..31eba9a 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -765,9 +765,8 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num,
>      uint32_t addr;
>      uint64_t wmask;
>  
> -    if ((unsigned int)region_num >= PCI_NUM_REGIONS)
> -        return;
> -
> +    assert(region_num >= 0);
> +    assert(region_num < PCI_NUM_REGIONS);
>      if (size & (size-1)) {
>          fprintf(stderr, "ERROR: PCI region size must be pow2 "
>                      "type=0x%x, size=0x%"FMT_PCIBUS"\n", type, size);
> -- 
> 1.7.1.1



reply via email to

[Prev in Thread] Current Thread [Next in Thread]