[Qemu-devel] Re: [PATCH 3/3] pci: improve signature of pci_register_bar().

[Michael S. Tsirkin]

On Thu, Sep 09, 2010 at 11:48:57AM +0900, Isaku Yamahata wrote:
> Make type uint8_t from int because PCIIORegion::type is uint8_t.
> 
> Signed-off-by: Isaku Yamahata <address@hidden>
> ---
>  hw/pci.c |    2 +-
>  hw/pci.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)


Applied, thanks.

> diff --git a/hw/pci.c b/hw/pci.c
> index 31eba9a..ceee291 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -758,7 +758,7 @@ static int pci_unregister_device(DeviceState *dev)
>  }
>  
>  void pci_register_bar(PCIDevice *pci_dev, int region_num,
> -                            pcibus_t size, int type,
> +                            pcibus_t size, uint8_t type,
>                              PCIMapIORegionFunc *map_func)
>  {
>      PCIIORegion *r;
> diff --git a/hw/pci.h b/hw/pci.h
> index bccab3a..25179eb 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -192,7 +192,7 @@ PCIDevice *pci_register_device(PCIBus *bus, const char 
> *name,
>                                 PCIConfigWriteFunc *config_write);
>  
>  void pci_register_bar(PCIDevice *pci_dev, int region_num,
> -                            pcibus_t size, int type,
> +                            pcibus_t size, uint8_t type,
>                              PCIMapIORegionFunc *map_func);
>  
>  int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
> -- 
> 1.7.1.1