[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/1] Fix loop logic in vhost_net_start()'s error pat
From: |
Jes . Sorensen |
Subject: |
[Qemu-devel] [PATCH 1/1] Fix loop logic in vhost_net_start()'s error path |
Date: |
Tue, 14 Sep 2010 12:06:12 +0200 |
From: Jes Sorensen <address@hidden>
file.index is unsigned, hence 'while (--file.index >= 0)' will loop
forever. Change it to do {} while (file.index-- > 0)
Signed-off-by: Jes Sorensen <address@hidden>
---
hw/vhost_net.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/vhost_net.c b/hw/vhost_net.c
index 4a7b819..b1f8072 100644
--- a/hw/vhost_net.c
+++ b/hw/vhost_net.c
@@ -151,10 +151,10 @@ int vhost_net_start(struct vhost_net *net,
return 0;
fail:
file.fd = -1;
- while (--file.index >= 0) {
+ do {
int r = ioctl(net->dev.control, VHOST_NET_SET_BACKEND, &file);
assert(r >= 0);
- }
+ } while (file.index-- > 0);
net->vc->info->poll(net->vc, true);
vhost_dev_stop(&net->dev, dev);
if (net->dev.acked_features & (1 << VIRTIO_NET_F_MRG_RXBUF)) {
--
1.7.2.2
- [Qemu-devel] [PATCH 1/1] Fix loop logic in vhost_net_start()'s error path,
Jes . Sorensen <=