[Qemu-devel] Re: [PATCH v5] Introduce qemu_madvise()

[Andreas Färber]

Am 14.09.2010 um 22:36 schrieb Blue Swirl:

> On Tue, Sep 14, 2010 at 8:28 PM, Andreas Färber <address@hidden 
> > wrote:
> > diff --git a/osdep.h b/osdep.h
> > index 1cdc7e2..6fb4ff3 100644
> > --- a/osdep.h
> > +++ b/osdep.h
> > @@ -90,6 +90,41 @@ void *qemu_memalign(size_t alignment, size_t  
> > size);
> >  void *qemu_vmalloc(size_t size);
> >  void qemu_vfree(void *ptr);
> >
> > +#define QEMU_MADV_INVALID -1
> > +
> > +#if defined(CONFIG_MADVISE)
> > +
> > +#define QEMU_MADV_WILLNEED  MADV_WILLNEED
> > +#define QEMU_MADV_DONTNEED  MADV_DONTNEED
> > +#ifdef MADV_DONTFORK
> > +#define QEMU_MADV_DONTFORK  MADV_DONTFORK
> > +#else
> > +#define QEMU_MADV_DONTFORK  QEMU_MADV_INVALID
> > +#endif
> > +#ifdef MADV_MERGEABLE
> > +#define QEMU_MADV_MERGEABLE MADV_MERGEABLE
> > +#else
> > +#define QEMU_MADV_MERGEABLE QEMU_MADV_INVALID
> > +#endif
> > +
> > +#elif defined(CONFIG_POSIX_MADVISE)
> > +
> > +#define QEMU_MADV_WILLNEED  POSIX_MADV_WILLNEED
> > +#define QEMU_MADV_DONTNEED  POSIX_MADV_DONTNEED
> > +#define QEMU_MADV_DONTFORK  POSIX_MADV_NORMAL
> > +#define QEMU_MADV_MERGEABLE POSIX_MADV_NORMAL
>
> Shouldn't these two (or at least QEMU_MADV_DONTFORK) be defined to
> QEMU_MADV_INVALID, so KVM check will fail as it should?

Oops, missed these two. Will fix tomorrow.

Thanks,
Andreas