[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 byt
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes) |
|
Date: |
Sat, 18 Sep 2010 22:12:13 +0100 |
On Sat, Sep 18, 2010 at 9:57 PM, Hervé Poussineau <address@hidden> wrote:
> Another patch creating ARP replies at least 64 bytes long has been
> committed:
> http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=dbf3c4b4baceb91eb64d09f787cbe92d65188813
>
> Does it fix your issue?
No I don't think so. This is an e1000 issue, it will happen if you
use tap networking too. The commit you linked to only affects slirp
and pads its ARP code.
I think there are two places where the minimum frame length can be enforced:
1. The NIC emulation code. This is currently how rtl8139, pcnet, and
ne2000 do it. My patch adds the same for e1000.
2. The net layer. If we're emulating Ethernet then it would be
possible to pad to minimum frame length in common networking code
(net.c).
Stefan