Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size (60 bytes)

[Stefan Hajnoczi]

On Sat, Sep 18, 2010 at 10:27 PM, Edgar E. Iglesias
<address@hidden> wrote:
> This doesn't look right. AFAIK, MAC's dont pad on receive.

I agree.  NICs that do padding will do it on transmit, not receive.
Anything coming in on the wire should already have the minimum length.

In QEMU that isn't true today and that's why rtl8139, pcnet, and
ne2000 already do this same padding.  This patch is the smallest
change to cover e1000.

> IMO this kind of padding should somehow be done by the bridge that forwards
> packets into the qemu vlan (e.g slirp or the generic tap bridge).

That should work and we can then drop the padding code from existing
NICs.  I'll take a look.

Stefan