[Qemu-devel] Re: [PATCH] Fix vhost_net compilation errors for i386-softmmu target

[Michal Novotny]

On 09/20/2010 07:53 PM, Michael S. Tsirkin wrote:
> On Mon, Sep 20, 2010 at 11:36:58AM +0200, Michal Novotny wrote:
>    
> > Hi,
> > there were compilation errors when I was trying to compile
> > i386-softmmu target on i386
> > host (running on Fedora-13 with development version of qemu
> > downloaded from git).
> >
> > There were errors of comparison of unsigned expression was always
> > true which made it
> > unable to compile. This simple fix fixes the issue.
> >
> > ...
> > cc1: warnings being treated as errors
> > .../hw/vhost_net.c: In function ‘vhost_net_start’:
> > .../vhost_net.c:154: error: comparison of unsigned expression>= 0
> > is always true
> > make[1]: *** [vhost_net.o] Error 1
> > make: *** [subdir-i386-softmmu] Error 2
> >
> > Signed-off-by: Michal Novotny<address@hidden>
> >
> > --
> > Michal Novotny<address@hidden>, RHCE
> > Virtualization Team (xen userspace), Red Hat
> >
> >      
> This is not the right fix though. I have queued
> the correct one on my tree, will send pull request.
>
>    

Oh, ok. Nevertheless according to the definition of file.index to be 
unsigned it can never be negative value so that's why I implemented the 
check against greater than zero rather than equal or greater than zero 
but maybe that's not the right way to fix it like you say. However, 
since your patch is already in the queue as you told me it's fine.

Michal

--
Michal Novotny<address@hidden>, RHCE
Virtualization Team (xen userspace), Red Hat