[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] blkverify: Handle overlapping I/O vector buffer
|
From: |
Kevin Wolf |
|
Subject: |
[Qemu-devel] Re: [PATCH] blkverify: Handle overlapping I/O vector buffers |
|
Date: |
Tue, 21 Sep 2010 12:06:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7 |
Am 20.09.2010 15:31, schrieb Stefan Hajnoczi:
> When blkverify clones an I/O vector in order to perform mirrored reads
> and then compare their contents, it does not take into account the
> layout of individual buffers. It turns out this is important because
> guests may issue requests with overlapping buffers and the results
> differ depending on how buffers are overlapped.
>
> This patch introduces logic to honor overlap relationships when cloning
> I/O vectors.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Took me a while to review this. These buffer calculations always look so
harmless, but it's not trivial at all...
Anyway, looks good to me.
Kevin