Re: [Qemu-devel] [PATCH RFC V3 04/12] xen: Add the Xen platform pci device

[Isaku Yamahata]

On Fri, Sep 17, 2010 at 12:14:59PM +0100, address@hidden wrote:

> +static uint32_t platform_mmio_read(void *opaque, target_phys_addr_t addr)
> +{
> +    static int warnings = 0;
> +
> +    if (warnings < 5) {
> +        DPRINTF("Warning: attempted read from physical address "
> +                "0x" TARGET_FMT_plx " in xen platform mmio space\n", addr);
> +        warnings++;
> +    }
> +    return 0;
> +}
> +
> +static void platform_mmio_write(void *opaque, target_phys_addr_t addr,
> +                                uint32_t val)
> +{
> +    static int warnings = 0;
> +
> +    if (warnings < 5) {
> +        DPRINTF("Warning: attempted write of 0x%x to physical "
> +                "address 0x" TARGET_FMT_plx " in xen platform mmio space\n",
> +                val, addr);
> +        warnings++;
> +    }
> +}
> +
> +static CPUReadMemoryFunc * const platform_mmio_read_funcs[3] = {
> +    platform_mmio_read,
> +    platform_mmio_read,
> +    platform_mmio_read,
> +};
> +
> +static CPUWriteMemoryFunc * const platform_mmio_write_funcs[3] = {
> +    platform_mmio_write,
> +    platform_mmio_write,
> +    platform_mmio_write,
> +};
> +
> +static void platform_mmio_map(PCIDevice *d, int region_num,
> +                              pcibus_t addr, pcibus_t size, int type)
> +{
> +    int mmio_io_addr;
> +
> +    mmio_io_addr = cpu_register_io_memory(platform_mmio_read_funcs,
> +                                          platform_mmio_write_funcs, NULL);
> +
> +    cpu_register_physical_memory(addr, size, mmio_io_addr);
> +}

Please use cpu_register_io_memory_simple().

-- 
yamahata