[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] block: Use GCC_FMT_ATTR and fix a format error
From: |
Stefan Weil |
Subject: |
[Qemu-devel] [PATCH] block: Use GCC_FMT_ATTR and fix a format error |
Date: |
Fri, 24 Sep 2010 21:02:05 +0200 |
Adding the gcc format attribute detects a format bug
which is fixed here.
v2:
Don't use type cast. BDRV_SECTOR_SIZE is unsigned long long,
so %lld should be the correct format specifier.
Cc: Blue Swirl <address@hidden>
Cc: Kevin Wolf <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
---
block/blkverify.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/blkverify.c b/block/blkverify.c
index 8083464..b2a12fe 100644
--- a/block/blkverify.c
+++ b/block/blkverify.c
@@ -53,7 +53,8 @@ static AIOPool blkverify_aio_pool = {
.cancel = blkverify_aio_cancel,
};
-static void blkverify_err(BlkverifyAIOCB *acb, const char *fmt, ...)
+static void GCC_FMT_ATTR(2, 3) blkverify_err(BlkverifyAIOCB *acb,
+ const char *fmt, ...)
{
va_list ap;
@@ -299,7 +300,7 @@ static void blkverify_verify_readv(BlkverifyAIOCB *acb)
{
ssize_t offset = blkverify_iovec_compare(acb->qiov, &acb->raw_qiov);
if (offset != -1) {
- blkverify_err(acb, "contents mismatch in sector %ld",
+ blkverify_err(acb, "contents mismatch in sector %lld",
acb->sector_num + (offset / BDRV_SECTOR_SIZE));
}
}
--
1.7.1
- [Qemu-devel] [PATCH] block: Use GCC_FMT_ATTR and fix a format error, Stefan Weil, 2010/09/23
- [Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error, Blue Swirl, 2010/09/23
- [Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error, Stefan Weil, 2010/09/23
- [Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error, Stefan Weil, 2010/09/23
- [Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error, Blue Swirl, 2010/09/23
- [Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error, Stefan Weil, 2010/09/23
- [Qemu-devel] [PATCH] block: Use GCC_FMT_ATTR and fix a format error,
Stefan Weil <=
- [Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error, Blue Swirl, 2010/09/25
- [Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error, Stefan Weil, 2010/09/25