Re: [Qemu-devel] [PATCH 3/8] [MIPS] qdev: convert jazz-led to sysbus device

[Markus Armbruster]

Hervé Poussineau <address@hidden> writes:

> Use it in Jazz emulation
> Remove jazz_led_init() function, which is not used anymore
> Compile jazz_led.c file only once
[...]
> diff --git a/hw/jazz_led.c b/hw/jazz_led.c
> index 4cb680c..f364301 100644
> --- a/hw/jazz_led.c
> +++ b/hw/jazz_led.c
[...]
> @@ -70,30 +70,18 @@ static uint32_t led_readb(void *opaque, 
> target_phys_addr_t addr)
>  static uint32_t led_readw(void *opaque, target_phys_addr_t addr)
>  {
>      uint32_t v;
> -#ifdef TARGET_WORDS_BIGENDIAN
> -    v = led_readb(opaque, addr) << 8;
> -    v |= led_readb(opaque, addr + 1);
> -#else
>      v = led_readb(opaque, addr);
>      v |= led_readb(opaque, addr + 1) << 8;
> -#endif
>      return v;
>  }

Stupid question: why can you drop the #if here?

[...]