qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] fix unsigned comparison warning in TCG


From: Hollis Blanchard
Subject: [Qemu-devel] fix unsigned comparison warning in TCG
Date: Sun, 26 Sep 2010 10:40:51 -0700

TCGOpcode is an enum, which apparently can be unsigned.

Signed-off-by: Hollis Blanchard <address@hidden>
---

% ./configure --target-list=ppcemb-softmmu --enable-debug
% make
  ...
  CC    ppcemb-softmmu/tcg/tcg.o
cc1: warnings being treated as errors
/home/hollisb/source/qemu.git/tcg/tcg.c: In function
‘tcg_add_target_add_op_defs’:
/home/hollisb/source/qemu.git/tcg/tcg.c:1030: error: comparison of
unsigned expression >= 0 is always true
% gcc -v
gcc version 4.4.4 20100630 (Red Hat 4.4.4-10) (GCC)

diff --git a/tcg/tcg.c b/tcg/tcg.c
index e0a9030..7e96859 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -1027,7 +1027,7 @@ void tcg_add_target_add_op_defs(const TCGTargetOpDef *tdef
         if (tdefs->op == (TCGOpcode)-1)
             break;
         op = tdefs->op;
-        assert(op >= 0 && op < NB_OPS);
+        assert(op < NB_OPS);
         def = &tcg_op_defs[op];
 #if defined(CONFIG_DEBUG_TCG)
         /* Duplicate entry in op definitions? */



reply via email to

[Prev in Thread] Current Thread [Next in Thread]