qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features


From: Avi Kivity
Subject: [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features
Date: Tue, 28 Sep 2010 11:37:58 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.4

 On 09/28/2010 11:28 AM, Roedel, Joerg wrote:
On Mon, Sep 27, 2010 at 12:22:13PM -0400, Avi Kivity wrote:
>    On 09/27/2010 05:40 PM, Roedel, Joerg wrote:
>  >  On Mon, Sep 27, 2010 at 11:02:23AM -0400, Avi Kivity wrote:
>  >  >     On 09/27/2010 04:58 PM, Avi Kivity wrote:
>  >  >   >    On 09/27/2010 03:16 PM, Joerg Roedel wrote:
>  >  >   >>   This patch adds the svm cpuid feature flags to the qemu
>  >  >   >>   intialization path. It also adds the svm features available
>  >  >   >>   on phenom to its cpu-definition and extends the host cpu
>  >  >   >>   type to support all svm features KVM can provide.
>  >  >   >>
>  >  >   >
>  >  >   >   This should really be "all svm features" since we'll later mask 
them
>  >  >   >   with kvm capabilities.  This way, if we later add more 
capabilities,
>  >  >   >   we automatically gain support in userspace.
>  >
>  >  Yes, that is what -cpu host does with these patches applied. The
>  >  svm_features variable is set to -1 in this case and masked out later
>  >  with the KVM capabilities.
>  >
>
>  Well, running current uq/master I get:
>
>     has_svm: can't execute cpuid 0x8000000a
>     kvm: no hardware support
>
>  ?

Weird, it worked here as I tested it. I had it on qemu/master and with
all three patches. But patch 1 should not make the difference. I take a
look, have you pushed the failing uq/master?

Yes, 8fe6a21c76.

What was your command line?

qemu-system-x86_64 -m 2G -cpu kvm64,+svm,+npt -enable-kvm ...

Note this is qemu.git, so -enable-kvm is needed.

--
error compiling committee.c: too many arguments to function




reply via email to

[Prev in Thread] Current Thread [Next in Thread]