[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 15/23] QMP: Small cleanup in handle_qmp_command()
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 15/23] QMP: Small cleanup in handle_qmp_command() |
Date: |
Fri, 1 Oct 2010 15:19:19 -0300 |
QMP has its own dispatch tables, we can now drop the following
checks:
o 'info' command: this command doesn't exist in QMP's
dispatch table, the right thing will happen when it's
issued by a client (ie. command not found error)
o monitor_handler_ported(): all QMP handlers are 'ported', no
need to check for that
o monitor_cmd_user_only(): no HMP handler will exist in QMP's
dispatch tables, that's why we have split them after all :-)
Signed-off-by: Luiz Capitulino <address@hidden>
---
monitor.c | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/monitor.c b/monitor.c
index 612ee56..6e62643 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4472,19 +4472,13 @@ static void handle_qmp_command(JSONMessageParser
*parser, QList *tokens)
goto err_out;
}
- /*
- * XXX: We need this special case until QMP has its own dispatch table
- */
- if (compare_cmd(cmd_name, "info")) {
- qerror_report(QERR_COMMAND_NOT_FOUND, cmd_name);
- goto err_out;
- } else if (strstart(cmd_name, "query-", &query_cmd)) {
+ if (strstart(cmd_name, "query-", &query_cmd)) {
cmd = qmp_find_query_cmd(query_cmd);
} else {
cmd = qmp_find_cmd(cmd_name);
}
- if (!cmd || !monitor_handler_ported(cmd) || monitor_cmd_user_only(cmd)) {
+ if (!cmd) {
qerror_report(QERR_COMMAND_NOT_FOUND, cmd_name);
goto err_out;
}
--
1.7.3.1.50.g1e633
- [Qemu-devel] [PATCH 05/23] QMP: handle_qmp_command(): Move 'cmd' sanity check, (continued)
- [Qemu-devel] [PATCH 05/23] QMP: handle_qmp_command(): Move 'cmd' sanity check, Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 06/23] QMP: Don't use do_info(), Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 08/23] Monitor: Drop is_async_return(), Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 07/23] Monitor: Drop QMP bits from do_info(), Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 09/23] Monitor: Convert do_info() back to HMP, Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 10/23] Monitor: Introduce the qmp-commands.hx file, Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 11/23] QMP: Introduce qmp_find_cmd(), Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 12/23] QMP: Introduce command dispatch table, Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 13/23] QMP: Introduce query commands dispatch table, Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 14/23] QMP: Simplify do_info_commands(), Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 15/23] QMP: Small cleanup in handle_qmp_command(),
Luiz Capitulino <=
- [Qemu-devel] [PATCH 17/23] Monitor: Drop monitor_cmd_user_only(), Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 16/23] Monitor: Drop QMP info from the qemu-monitor.hx file, Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 20/23] Monitor: Directly call QObject handlers, Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 21/23] QMP: Introduce qmp_call_cmd(), Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 22/23] Monitor: Rename the qemu-monitor.hx file, Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 23/23] QMP/README: Update QMP homepage address, Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 19/23] Monitor: Rename monitor_handler_is_async(), Luiz Capitulino, 2010/10/01
- [Qemu-devel] [PATCH 18/23] Monitor: Rename monitor_handler_ported(), Luiz Capitulino, 2010/10/01
- Re: [Qemu-devel] [PULL 00/23]: Monitor queue, Anthony Liguori, 2010/10/05