[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation
From: |
John Clark |
Subject: |
Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation |
Date: |
Sat, 02 Oct 2010 13:04:36 -0400 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100915 Thunderbird/3.0.8 |
>>>>
>>>> -target_ulong helper_4xx_tlbre_hi (target_ulong entry)
>>>> +target_ulong helper_4xx_tlbre_lo (target_ulong entry)
>>>
>>> Huh?
>>
>> To summarize, 'tlbre' has two forms: one to retrieve the high bits of
>> a TLB entry (TLBHI), and one to retrieve the low bits (TLBLO) of a TLB
>> entry. This code had the TLBLO form returning the bits corresponding
>> to TLBHI and vice versa, hence the name change. You can verify this
>> if you like with this IBM PowerPC 405 core user manual on page 362:
>
> Well the thing that strikes me as weird is mostly that you're changing a
> function name, but no callers to it. So is this function never used? Or was
> tlbre_lo defined before already and is now defined twice?
You'll see that helper_4xx_tlbre_hi changes to helper_4xx_tlbre_lo and
that helper_4xx_tlbre_lo changes to helper_4xx_tlbre_hi, so
helper_4xx_tlbre_lo is not multiply defined.
>
> PS: Please use the "reply to all" function of your mailer. Others might be
> interested in the reply too :).
>
Yes, I realized my mistake a few minutes after sending the previous
reply and corrected it.
- John
- [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation, John Clark, 2010/10/02
- Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation, Alexander Graf, 2010/10/02
- Message not available
- Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation, Alexander Graf, 2010/10/02
- Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation,
John Clark <=
- Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation, Edgar E. Iglesias, 2010/10/02
- Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation, Alexander Graf, 2010/10/02
- Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation, John Clark, 2010/10/02
- Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation, Alexander Graf, 2010/10/05
- Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation, Edgar E. Iglesias, 2010/10/05