qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] virtio-9p.c:401: v9fs_string_sprintf: Assertion `!(err


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] virtio-9p.c:401: v9fs_string_sprintf: Assertion `!(err == -1)' failed.
Date: Wed, 6 Oct 2010 15:42:04 +0100

On a related note, there are more uses of BUG_ON() in hw/virtio-9p.c
which can be triggered from the guest:

submit_pdu():
    BUG_ON(pdu->id >= ARRAY_SIZE(pdu_handlers));
    BUG_ON(handler == NULL);

handle_9p_output():
        BUG_ON(pdu->elem.out_num == 0 || pdu->elem.in_num == 0);
        BUG_ON(pdu->elem.out_sg[0].iov_len < 7);

These should be handled by skipping the bad virtqueue element.  We
could also reset the device but that may freak out the (bad) guest.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]