qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 11/11] mips: avoid write only variables


From: Markus Armbruster
Subject: Re: [Qemu-devel] Re: [PATCH 11/11] mips: avoid write only variables
Date: Thu, 07 Oct 2010 14:35:50 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

> On 10/06/2010 11:34 PM, Blue Swirl wrote:
>> Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
>> /src/qemu/target-mips/translate.c: In function 'gen_ld':
>> /src/qemu/target-mips/translate.c:1039:17: error: variable 'opn' set
>> but not used [-Werror=unused-but-set-variable]
>>
>> Fix by making the variable declarations and uses conditional to debugging.
>
> What about a set_opn macro instead of this one-off "D" idiom?

Even simpler: a few judiciously placed (void)opn.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]