[Qemu-devel] Re: [PATCH 08/11] vnc: avoid write only variables

[Blue Swirl]

On Thu, Oct 7, 2010 at 7:23 AM, Paolo Bonzini <address@hidden> wrote:
> On 10/06/2010 11:33 PM, Blue Swirl wrote:
>>
>> +#if defined(CONFIG_VNC_TLS) || defined(CONFIG_VNC_SASL)
>>          } else if (strncmp(options, "acl", 3) == 0) {
>>              acl = 1;
>> +#endif
>
> Not sure it's okay to reject the option altogether (i.e. maybe the #if
> should only include "acl = 1".

It's OK with current code, it doesn't check for invalid options. This
also matches how other options are handled.