[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] check for close() errors on qcow2_create()
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] check for close() errors on qcow2_create() |
|
Date: |
Fri, 8 Oct 2010 12:29:02 -0300 |
|
User-agent: |
Mutt/1.5.20 (2009-08-17) |
On Fri, Oct 08, 2010 at 10:28:37AM +0100, Stefan Hajnoczi wrote:
> > exit_close:
> > - close(fd);
> > + cret = close(fd);
> > + if (ret == 0 && cret < 0)
>
> if (close(fd) < 0 && ret == 0) {
>
> Does the same without variable cret.
Yes. I used the variable just for readability. I personally don't like
having side-effects inside a if condition.
--
Eduardo