Re: [Qemu-devel] Re: [PATCH 04/11] lsi53c895a: avoid a write only variable

[Paolo Bonzini]

On 10/07/2010 08:53 PM, Blue Swirl wrote:
> On Thu, Oct 7, 2010 at 9:20 AM, Markus Armbruster<address@hidden>  wrote:
> > Paolo Bonzini<address@hidden>  writes:
> >
> > > On 10/06/2010 11:32 PM, Blue Swirl wrote:
> > > > Compiling with GCC 4.6.0 20100925 produced a warning:
> > > > /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':
> > > > /src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not
> > > > used [-Werror=unused-but-set-variable]
> > > >
> > > > Fix by making the variable declaration and its uses also conditional
> > > > to debug definition.
> > >
> > > NACK, this uglifies the code and loses track of _what_ is that msgbyte
> > > we're reading.
>
> That information could be saved by adding a comment, I used that
> approach for vmstate.c.

Yes, that's fine for vmstate.c, but here you are also uselessly 
duplicating the code.  (void) len is good though.  I suggest doing the 
same for i386 too (and there you could put a reference to the manual).

Paolo