[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/12] mips_fulong2e: Delete write only variable
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/12] mips_fulong2e: Delete write only variables |
|
Date: |
Mon, 11 Oct 2010 16:55:49 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Blue Swirl <address@hidden> writes:
> Compiling with GCC 4.6.0 20100925 produced warnings like:
> /src/qemu/hw/mips_fulong2e.c: In function 'mips_fulong2e_init':
> /src/qemu/hw/mips_fulong2e.c:274:16: error: variable 'rtc_state' set
> but not used [-Werror=unused-but-set-variable]
> /src/qemu/hw/mips_fulong2e.c:268:16: error: variable 'isa_dev' set but
> not used [-Werror=unused-but-set-variable]
> /src/qemu/hw/mips_fulong2e.c:261:19: error: variable 'ram_offset' set
> but not used [-Werror=unused-but-set-variable]
>
> Fix by removing the unused variables.
>
> Instead of removing, fix ram_offset use.
That part looks like a bug fix to me! Suggest to put it in its own
commit, with a commit message describing its impact.