Re: [Qemu-devel] [PATCH 13/39] properly detect compiler in tests/Makefile

[Blue Swirl]

On Tue, Oct 12, 2010 at 1:00 PM, Paolo Bonzini <address@hidden> wrote:
> `make speed' only makes sense if not cross-compiling, so sha1 can
> use the CC for the system that is hosting qemu.  sha1-i386 is also
> wrong, since there is usually no variable for the target CC; guess
> some plausible values.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  tests/Makefile |   14 ++++++++++++--
>  1 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index ff7f787..a789e2d 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -64,11 +64,21 @@ linux-test: linux-test.c
>        $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< -lm
>
>  # speed test
> +ifeq ($(shell uname -m), x86_64)
> +CC_I386 = $(CC) -m32
> +else
> +ifeq ($(shell uname -m), i386)
> +CC_I386 = $(CC)
> +else
> +CC_I386 = i386-pc-linux-gnu-$(CC)
> +endif
> +endif

I'd move this logic to configure.