qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] QEMU host support


From: Andreas Färber
Subject: Re: [Qemu-devel] QEMU host support
Date: Sat, 16 Oct 2010 11:14:39 +0200

Am 16.10.2010 um 09:46 schrieb Stefan Hajnoczi:

On Fri, Oct 15, 2010 at 5:51 PM, Jes Sorensen <address@hidden> wrote:
Looking through some code in qemu-char.c I was wondering if we support any other QEMU host target than Win32 which isn't covered by these defines:

#if defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \
   || defined(__NetBSD__) || defined(__OpenBSD__) ||
defined(__DragonFly__) \
   || defined(__GLIBC__)

What about Haiku?  It uses __HAIKU__ but I'm not sure if it defines
__GLIBC__ or even one of the others.

Apparently it doesn't define __GLIBC__ (it has a libroot that contains parts of glibc only). It definitely doesn't define any of the others.

If I add  || defined (__HAIKU__) to the list above, I get:

  CC    qemu-char.o
/Data/QEMU/qemu/qemu-char.c: In function 'qemu_chr_open_pty':
/Data/QEMU/qemu/qemu-char.c:982: warning: implicit declaration of function 'openpty' /Data/QEMU/qemu/qemu-char.c:982: warning: nested extern declaration of 'openpty' /Data/QEMU/qemu/qemu-char.c:988: warning: implicit declaration of function 'cfmakeraw' /Data/QEMU/qemu/qemu-char.c:988: warning: nested extern declaration of 'cfmakeraw'
/Data/QEMU/qemu/qemu-char.c: In function 'tty_serial_ioctl':
/Data/QEMU/qemu/qemu-char.c:1149: error: 'TIOCMGET' undeclared (first use in this function) /Data/QEMU/qemu/qemu-char.c:1149: error: (Each undeclared identifier is reported only once /Data/QEMU/qemu/qemu-char.c:1149: error: for each function it appears in.) /Data/QEMU/qemu/qemu-char.c:1151: error: 'TIOCM_CTS' undeclared (first use in this function) /Data/QEMU/qemu/qemu-char.c:1153: error: 'TIOCM_CAR' undeclared (first use in this function) /Data/QEMU/qemu/qemu-char.c:1155: error: 'TIOCM_DSR' undeclared (first use in this function) /Data/QEMU/qemu/qemu-char.c:1157: error: 'TIOCM_RI' undeclared (first use in this function) /Data/QEMU/qemu/qemu-char.c:1159: error: 'TIOCM_DTR' undeclared (first use in this function) /Data/QEMU/qemu/qemu-char.c:1161: error: 'TIOCM_RTS' undeclared (first use in this function) /Data/QEMU/qemu/qemu-char.c:1184: error: 'TIOCMSET' undeclared (first use in this function)
make: *** [qemu-char.o] Error 1

openpty() is defined in Haiku's BSD compatibility layer, in pty.h. Hacking the FreeBSD #include code path makes QEMU find it. There's no cfmakeraw(). Reusing the one from the Sun code path seems to work.

I believe these TIOCM* defines were not supported in Haiku and we didn't find out where they originate from. They were not in POSIX. Anyone know off-hand?

Andreas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]