|
From: | Paolo Bonzini |
Subject: | [Qemu-devel] Re: [PATCH 08/10] MCE: Relay UCR MCE to guest |
Date: | Wed, 20 Oct 2010 23:56:55 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100907 Fedora/3.1.3-1.fc13 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.3 |
On 10/20/2010 09:51 PM, Anthony Liguori wrote:
I don't understand why this loop is needed but we specifically wait for a signal to get delivered that's either SIG_IPI or SIGBUS. We then check whether a SIG_IPI or SIGBUS is pending and loop waiting for signals again. Shouldn't we be looping on just sigismember(SIGBUS)?
You mean because SIG_IPI is a real-time signal and standard signals are delivered first? OTOH, real-time signals can be queued multiple times so it makes sense to loop on SIG_IPI as well.
BTW, we're no longer respecting timeout because we're not adjusting ts after each iteration.
The timeout of qemu_kvm_eat_signal is always zero. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |