[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] ide: Handle flush failure
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] ide: Handle flush failure |
Date: |
Thu, 21 Oct 2010 07:21:32 +0200 |
User-agent: |
Mutt/1.3.28i |
On Tue, Oct 19, 2010 at 05:08:52PM +0200, Kevin Wolf wrote:
> Instead of always assuming success for bdrv_aio_flush, actually do something
> with the error. This respects the werror option and accordingly ignores the
> error, reports it to the guest or stops the VM and retries after cont.
>
> Ignoring the error is trivial, obviously. For stopping the VM and retrying
> later old code can be reused, but we need to introduce a new status for "retry
> a flush". For reporting to the guest, fortunately the same action is required
> as for a failed read/write (status = DRDY | ERR, error = ABRT), so this code
> can be reused as well.
ACK