[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it |
Date: |
Fri, 22 Oct 2010 09:59:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
address@hidden writes:
> From: Jes Sorensen <address@hidden>
>
> This patch introduces cutils.c: strtosz() and gets rid of the
> multiple custom hacks for parsing byte sizes. In addition it adds
> supports for specifying human style sizes such as 1.5G. Last it
> eliminates the horrible abuse of a float to store the byte size for
> migrate_set_speed in the monitor.
>
> Note, this is tested on Linux and build tested for win32 using
> mingw32.
>
> v9: I worked through a couple of revisions directly with Markus and I
> think I got it right finally.
I'd prefer to have strtosz() to match strtol() & friends and not
restrict suffixes. But this code does what it claims to do, as far as I
can see, so:
ACK series