Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

[Anthony Liguori]

On 10/22/2010 09:38 AM, Michael S. Tsirkin wrote:
> On Fri, Oct 22, 2010 at 01:35:47PM +0200, Markus Armbruster wrote:
>    
> > "Michael S. Tsirkin"<address@hidden>  writes:
> >
> >      
> > > On Wed, Oct 20, 2010 at 05:18:56PM +0900, Isaku Yamahata wrote:
> > >        
> > > > glue pcie_push_attention_button command.
> > > >
> > > > Signed-off-by: Isaku Yamahata<address@hidden>
> > > >          
> > > So as a high level command, I think we need to
> > > think about how to tie this into pci_add/pci_del.
> > > Right?
> > >        
> > [...]
> >
> > Do we have consensus how our set of commands for hot plug should look
> > like?  We talked about it, but did we reach consensus?  If yes, did we
> > write it down somewhere?
> >      
> I think for simple things yes:
> - command to send hotplug notification to the guest
> - command to immediately add/remove the device
> - event to notify about guest ack
>    

Is it a guest ack?  I thought it was actually an eject that can be 
initiated without the notification being sent to the guest.

If so, polling doesn't really make much sense.

Regards,

Anthony Liguori

> - way to poll status: did guest ack last command?
>
> Existing ones will keep function:
> - send notification and when acked remove device
> - add device and send notification
> These are useful for human monitor but maybe not
> for management.
>
>
>