Re: [Qemu-devel] [RFC][PATCH 01/10] virtagent: add common rpc transport defs

[malc]

On Mon, 25 Oct 2010, Anthony Liguori wrote:

> On 10/22/2010 01:45 PM, Michael Roth wrote:
> > Common code for sending/recieving RPCs via http over virtproxy channel.
> > Eventually these will all be switched to asynchronous handlers to avoid
> > deadlocks between qemu and the guest. For now we can usually get away with
> > just doing asynchronous reads for http/RPC responses if we don't send
> > large RPC requests to the guest (since these will likely get buffered
> > rather than block or cause spinning on writes).
[..snip..]

> 
> expressions need spaces.  IOW, i=0; i<len; ++i should be i = 0; i < len; i++.
> 
> Avoid C++ isms like ++i.

Why? 

[..snip..]

-- 
mailto:address@hidden