[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation |
Date: |
Mon, 1 Nov 2010 15:51:02 -0400 |
On 01.11.2010, at 14:42, Stefan Weil wrote:
> Am 01.11.2010 19:29, schrieb Blue Swirl:
>> On Mon, Nov 1, 2010 at 3:01 PM, Alexander Graf<address@hidden> wrote:
>>
>>> ---
>>> hw/elf_ops.h | 61
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>> hw/loader.c | 7 ++++++
>>> hw/loader.h | 3 ++
>>> 3 files changed, 70 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/hw/elf_ops.h b/hw/elf_ops.h
>>> index 8b63dfc..645d058 100644
>>> --- a/hw/elf_ops.h
>>> +++ b/hw/elf_ops.h
>>> @@ -189,6 +189,44 @@ static int glue(load_symbols, SZ)(struct elfhdr *ehdr,
>>> int fd, int must_swab,
>>> return -1;
>>> }
>>>
>>> +static void glue(elf_read_notes, SZ)(uint8_t *data, int data_len,
>>> + ElfHandlers *handlers, int must_swab)
>>> +{
>>> + uint8_t *p = data;
>>> +
>>> + while ((ulong)&p[3]< (ulong)&data[data_len]) {
>>>
>> Please use 'unsigned long'.
>>
>
> Why is a type cast used here? I see no reason for it.
Pointers can't be compared, you have to cast them to values first.
Alex
- Re: [Qemu-devel] [PATCH 30/40] xenner: libxc emu: memory mapping, (continued)
- [Qemu-devel] [PATCH 24/40] xenner: kernel: printk, Alexander Graf, 2010/11/01
- [Qemu-devel] [PATCH 25/40] xenner: kernel: KVM PV code, Alexander Graf, 2010/11/01
- [Qemu-devel] [PATCH 02/40] elf: Add notes implementation, Alexander Graf, 2010/11/01
- Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation, Blue Swirl, 2010/11/01
- Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation, Stefan Weil, 2010/11/01
- Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation,
Alexander Graf <=
- Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation, Stefan Weil, 2010/11/01
- Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation, Alexander Graf, 2010/11/01
- [Qemu-devel] Re: [PATCH 02/40] elf: Add notes implementation, Paolo Bonzini, 2010/11/01
- Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation, Stefan Weil, 2010/11/01
- Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation, Michael Matz, 2010/11/02
[Qemu-devel] Re: [PATCH 02/40] elf: Add notes implementation, Paolo Bonzini, 2010/11/01