[Qemu-devel] Re: [PATCH] Overwrite argv to set process title, eliminating 16-character prctl() limit.

[John Morrissey]

On Sun, Nov 07, 2010 at 07:27:22PM +0100, Andreas Färber wrote:
> Am 07.11.2010 um 16:44 schrieb John Morrissey:
> >@@ -149,20 +145,24 @@ char *os_find_datadir(const char *argv0)
> >#undef SHARE_SUFFIX
> >#undef BUILD_SUFFIX
> >
> >-void os_set_proc_name(const char *s)
> >+void os_set_proc_name(int argc, char **argv, const char *name)
> >{
> >-#if defined(PR_SET_NAME)
> >-    char name[16];
> >-    if (!s)
> >+#ifdef CONFIG_LINUX
> 
> Is PR_SET_NAME defined outside Linux? If so, then your patch removes
> the limited functionality for those platforms completely.

PR_SET_NAME is defined in sys/prctl.h which, before this patch, was
conditionally included only on Linux platforms (CONFIG_LINUX).

Additionally, prctl(2) says:

  CONFORMING TO
         This  call  is  Linux-specific.

john
-- 
John Morrissey          _o            /\         ----  __o
address@hidden        _-< \_          /  \       ----  <  \,
www.horde.net/    __(_)/_(_)________/    \_______(_) /_(_)__